Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kms account manager #5

Merged
merged 110 commits into from
May 8, 2024
Merged

feat: kms account manager #5

merged 110 commits into from
May 8, 2024

Conversation

johnson2427
Copy link
Collaborator

What I did

Added AWS CLI tool for KMS and IAM
Developed out accounts.py to allow for signing messages and transactions

How I did it

fought through serialization issues, calculation of v issues, added clients, and aws-cli work

How to verify it

pytests

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@johnson2427
feat: add accounts python file
79d6ad1
@johnson2427
feat: accounts container functional
799b158
@johnson2427
feat: add signing feature
bfa8fe2
@johnson2427
feat: added signable message and eip191
9f8d9f9
@johnson2427
feat: attempting to verify DER encoded message
602685e
@johnson2427
feat: fix ape version
456e2e3
@johnson2427
feat: eth checksum address properly calculated
fb1e0fe
@johnson2427
feat: sign_message fully operational
37010f2
@johnson2427
feat: cleanup accounts and utils
692c8ea
@johnson2427
feat: remove list from eth_account import
59ac686
@johnson2427
feat: sign transactions in working state
6437521
@johnson2427
feat: rename ape_aws_kms folder and touch up readme
c7276e5
@johnson2427
feat: adding key import, not finished
b79ff59
@johnson2427
feat: add eip-155 note
6169759
@johnson2427
feat: accounts and cli work, fixing sign_transactions
43d6cee
@johnson2427
feat: change write_to value
490578e
@johnson2427
feat: add 312 support
2fa428d
@johnson2427
feat: move conver_der_to_rsv to utils
9390655
@johnson2427
feat: move functionality around to clean things up
505e958
@johnson2427
feat: remove print
ca7daf8
@johnson2427
feat: adding admin features and kms create and delete
40c2f61
@johnson2427
feat: add suggested changes for signing transactions
76a3304
@johnson2427
feat: remove unused code from utils
6f8c33a
@johnson2427
feat: remove check sig
b00d83a
@johnson2427
feat: pushing up for testing
ce83d4a
@johnson2427
feat: remove the need to import AwsAccountContainer
4f6e5bd
@johnson2427
feat: add ape_cli_context
f82a2e4
@johnson2427
feat: add cli_ctx use
62b4a61
@johnson2427
feat: fix bad function call
3b972e1
@johnson2427
feat: reduce function call names
9a82057
@fubuloubu fubuloubu changed the title Feat/kms manager feat: kms account manager May 8, 2024
fubuloubu
fubuloubu reviewed May 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fubuloubu
Copy link
Member

Also keep the py.typed file

fubuloubu
fubuloubu approved these changes May 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@johnson2427 johnson2427 merged commit 5aaad77 into main May 8, 2024
17 of 18 checks passed
@johnson2427 johnson2427 deleted the feat/kms-manager branch May 8, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnson2427 @fubuloubu