Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pep-625 compliance and python 3.13 update #16

Merged
merged 2 commits into from
Dec 12, 2024
Merged

chore: pep-625 compliance and python 3.13 update #16

merged 2 commits into from
Dec 12, 2024

Conversation

bitwise-constructs
Copy link
Contributor

What I did

Fixes: APE-1853
Fixes: APE-1855

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@bitwise-constructs bitwise-constructs enabled auto-merge (squash) December 5, 2024 21:30
@antazoey antazoey requested a review from fubuloubu December 5, 2024 21:39
fubuloubu
fubuloubu approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A refactor is currently in work here to bring it up to date

@antazoey
Copy link
Member

A refactor is currently in work here to bring it up to date

Should we merge this now or wait?

@fubuloubu
Copy link
Member

A refactor is currently in work here to bring it up to date

Should we merge this now or wait?

Can merge now, I think some people are using this with Silverback even though it's in alpha status

@antazoey antazoey disabled auto-merge December 12, 2024 16:13
@antazoey antazoey merged commit c5de08f into ApeWorX:main Dec 12, 2024
2 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antazoey antazoey antazoey approved these changes

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitwise-constructs @antazoey @fubuloubu