Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where empty results were not returned properly from make_request() #96

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jan 6, 2025

What I did

fixes: ApeWorX/ape#2456
fixes: ApeWorX/ape#2452

cursed walrus operator pwned us

How I did it

return emptiness when be it

How to verify it

demo that the user's reported issue is fixed:

ape console --network blast:mainnet:alchemy
In [1]: transfers = Contract("0xb1a5700fa2358173fe465e6ea4ff52e36e88e2ad").Transfer.range(0, chain.blocks[-1].number)

In [2]: list(transfers)

note: it does not fail anymore but the quest is so big that I am not going to actually wait for it to finish (searching entire blast chain for events?!) but before it failed right away and now it chugs along so we should be gucci

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey merged commit 4c29eb8 into main Jan 6, 2025
26 checks passed
@antazoey antazoey deleted the fix/empty-result branch January 6, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants