Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PoA detect and add amoy #84

Merged
merged 2 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion ape_alchemy/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@
from requests import HTTPError
from web3 import HTTPProvider, Web3
from web3.exceptions import ContractLogicError as Web3ContractLogicError
from web3.exceptions import ExtraDataLengthError
from web3.gas_strategies.rpc import rpc_gas_price_strategy
from web3.middleware import geth_poa_middleware
from web3.middleware import geth_poa_middleware as ExtraDataToPOAMiddleware
from web3.middleware.validation import MAX_EXTRADATA_LENGTH
from web3.types import RPCEndpoint

from .exceptions import AlchemyFeatureNotAvailable, AlchemyProviderError, MissingProjectKeyError
Expand Down Expand Up @@ -119,19 +122,44 @@ def connection_str(self) -> str:

def connect(self):
self._web3 = Web3(HTTPProvider(self.uri))
is_poa = None
try:
# Any chain that *began* as PoA needs the middleware for pre-merge blocks
base = 8453
optimism = 10
polygon = 137
polygon_amoy = 80002

if self._web3.eth.chain_id in (base, optimism, polygon):
if self._web3.eth.chain_id in (base, optimism, polygon, polygon_amoy):
self._web3.middleware_onion.inject(geth_poa_middleware, layer=0)
is_poa = True

self._web3.eth.set_gas_price_strategy(rpc_gas_price_strategy)
except Exception as err:
raise ProviderError(f"Failed to connect to Alchemy.\n{repr(err)}") from err

if is_poa is None:
# Check if is PoA but just wasn't as such yet.
# NOTE: We have to check both earliest and latest
# because if the chain was _ever_ PoA, we need
# this middleware.
for option in ("earliest", "latest"):
try:
block = self.web3.eth.get_block(option) # type: ignore[arg-type]
except ExtraDataLengthError:
is_poa = True
break
else:
is_poa = (
"proofOfAuthorityData" in block
or len(block.get("extraData", "")) > MAX_EXTRADATA_LENGTH
)
if is_poa:
break

if is_poa and ExtraDataToPOAMiddleware not in self.web3.middleware_onion:
self.web3.middleware_onion.inject(ExtraDataToPOAMiddleware, layer=0)

def disconnect(self):
self._web3 = None

Expand Down
1 change: 1 addition & 0 deletions tests/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def test_http(provider):
assert provider.http_uri.startswith("https")
assert provider.get_balance(ZERO_ADDRESS) > 0
assert provider.get_block(0)
assert provider.get_block("latest")


def test_ws(provider):
Expand Down
Loading