Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for polygon-zkevm networks #75

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jul 3, 2024

self explanatory

also required fixing something with multiname network names in API key check

also was forced to have weird handling for not-implemented on a couple methods because was just getting empty 400s and couldnt really do anything with those

@antazoey antazoey force-pushed the feat/polygon-zkevm branch from 295b8e7 to 5b845a8 Compare July 3, 2024 19:33
@antazoey antazoey requested a review from fubuloubu July 3, 2024 20:14
@antazoey antazoey marked this pull request as draft July 3, 2024 20:32
@antazoey antazoey marked this pull request as ready for review July 3, 2024 20:41
@antazoey
Copy link
Member Author

antazoey commented Jul 3, 2024

@fubuloubu
Copy link
Member

a TODO might be to add more support for zkEVM Methods

zkevm_consolidatedBlockNumber zkevm_isBlockConsolidated zkevm_isBlockVirtualized zkevm_batchNumberByBlockNumber zkevm_batchNumber zkevm_virtualBatchNumber zkevm_verifiedBatchNumber zkevm_getBatchByNumber zkevm_getBroadcastURI

Not too terribly interested in diving down that rabbit hole unless people really need it

@antazoey antazoey merged commit 5c44fd8 into main Jul 3, 2024
25 checks passed
@antazoey antazoey deleted the feat/polygon-zkevm branch July 3, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants