forked from Skyrat-SS13/Skyrat-tg
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Port of several PRs from NOVA (Skyrat-SS13#25926)
* Fixes confetti shotgun shells (Skyrat-SS13#174) * initial * fix confetti shell * donkpocket sprites and more * this is for a different PR * forgot these * ..() * reviews * // instead of /// for overrides --------- Co-Authored-By: Bloop <[email protected]> * New Quirk: Appendicitis Survivor (Skyrat-SS13#77) ## About The Pull Request Title. ## How This Contributes To The Nova Sector Roleplay Experience Spontaneous appendicitis is.. an event! This adds the Appendicitis Survivor quirk from my server, [TaleStation](https://github.com/TaleStation/TaleStation). Its a positive (-2) quirk, while low impact, some people may appreciate. Its also another low cost quirk, so people could pick it up if so desired. ## Proof of Testing <details> <summary>Screenshots/Videos</summary> ![image](https://github.com/GalacticStation/GalaxiaStation/assets/70232195/1f807368-f811-4d1d-b2c5-34f8508e6fcb) </details> ## Changelog :cl: Jolly add: New quirk for those who hate their appendix: Appendicitis Survivor! A positive (-2) quirk. /:cl: * Improves the names, descriptions, and extended descriptions of nearly all my firearms (Skyrat-SS13#90) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Three steps 1. Guns no longer list their company in their name, this made some gun names too long to refer to or just look weird. 2. Every gun now tells you what it fires in its examine if it didn't before. 3. Every gun's examine text now hints that you can double examine for more info on the weapon. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Makes a lot of information about these weapons more convenient or more apparent than they were before, and removes some unneeded information (like we didnt really have to have the guys that made the gun displayed straight in the name, you can see the company that makes them in the examine text already). <!-- Please add a short description of why you think these changes would benefit the game and the roleplay atmosphere of the server. If you can't justify it in words, it might not be worth adding. --> <!-- Include any screenshots/videos/debugging steps of the code functioning successfully, between the </summary> and </details> code blocks. --> <!-- To our mappers and spriters: Posting screenshots of content INSIDE EDITORS (aseprite, PDN, SDMM, ect) is NOT valid proof of testing. Please make sure that you COMPILE the game and provide PROOF you tested your edits. --> <details> <summary>Screenshots/Videos</summary> ![image](https://github.com/GalacticStation/GalaxiaStation/assets/82386923/cd4976fe-c641-4464-82ee-935aff63f159) ![image](https://github.com/GalacticStation/GalaxiaStation/assets/82386923/b1dc1edc-72fd-4235-a47d-84c36cae0679) </details> <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: qol: The names and descriptions of every paxilmaniac weapon have been improved to be shorter (names) and mention at least what bullet the weapon fires (description) qol: Every weapon with an extended description has a hint in its normal examine telling you that you can look further to get more info on the weapon code: Two instances of now-deleted weapons paths (which i found out about through someone getting one in a christmas tree) existing due to manufacturer examines of all things have been cleaned up, players wont notice this one i think /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> * Re-adding Cat Scream (Normalized) (Skyrat-SS13#123) * Re-adding Cat Scream (Normalized) * Update modular_nova/modules/emotes/code/scream_datums.dm Renamed the file from cat.ogg to cat_scream.ogg Co-authored-by: GoldenAlpharex <[email protected]> * Renamed cat.ogg to cat_scream.ogg * removed cat.ogg and replaced with cat_scream.ogg * Removes old scream sounds, renames it properly --------- Co-authored-by: GoldenAlpharex <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]> * [MODULAR] Fixes clockcult slab ui, some runtimes (Skyrat-SS13#122) Fixes slab ui, some runtimes * [MODULAR] Fixes colonial cloaks not being able to hold any suit storage items (Skyrat-SS13#129) * Fixes imperial police cloak not being able to hold any suit storage items * Moves this to the NRI police cloak * Moves this to the NRI police cloak * Update clothing.dm * Update modular_nova/modules/novaya_ert/code/police_outfit.dm --------- Co-authored-by: GoldenAlpharex <[email protected]> * Resprited Vox Clothing (Nova Station Edition) (Skyrat-SS13#97) * Resprited Vox Clothing * Update screenshot_humanoids__datum_species_vox_primalis.png --------- Co-authored-by: Bloop <[email protected]> * Chitter emote is the TG chitter sound unless you're a moth (Skyrat-SS13#111) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Changes the *chitter emote to play the standard TG chitter sfx, unless you're a moth, then it plays the moth chitter. TG chitter is cute. <!-- Include any screenshots/videos/debugging steps of the code functioning successfully, between the </summary> and </details> code blocks. --> <!-- To our mappers and spriters: Posting screenshots of content INSIDE EDITORS (aseprite, PDN, SDMM, ect) is NOT valid proof of testing. Please make sure that you COMPILE the game and provide PROOF you tested your edits. --> <details> <summary>Screenshots/Videos</summary> https://github.com/NovaSector/NovaSector/assets/77534246/eae4fc45-d104-4588-8537-394da9304151 </details> <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: add: Chitter emote has a different sound effect, unless you're a moth /:cl: * Adds fancy masquerade masks (Skyrat-SS13#180) * Adds masquerade masks, making them available in the AutoDrobe Thanks to Crumpaloo for the sprites! * Early mirror of tgstation/tgstation#80663 They're not properly usable otherwise * Updates the sprites so they've got transparent eyes * Adds the masks to the loadout * Fixes variation flags and muzzled GAGS config, makes it act as internals * Adjust some of the sprites a bit more, making snouted ones have smaller eyeholes, and vox ones looking more like masquerade masks * Updates the sprites for the Vox Primalis! --------- * Update greyscale_configs.dm * Fixes Niftsoft Settings Panel (Skyrat-SS13#208) Fixes Niftsoft Settings * 0 --------- Co-authored-by: Bloop <[email protected]> Co-authored-by: Kyogon <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]> Co-authored-by: HalcyonicWolf <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
- Loading branch information
1 parent
ccd16af
commit 1e5b718
Showing
49 changed files
with
348 additions
and
73 deletions.
There are no files selected for viewing
Binary file modified
BIN
-9 Bytes
(99%)
...les/unit_tests/screenshots/screenshot_humanoids__datum_species_vox_primalis.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+7.27 KB
(1200%)
modular_skyrat/master_files/icons/mob/clothing/species/vox/belt.dmi
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added
BIN
+1.02 KB
modular_skyrat/modules/GAGS/icons/mask/masquerade_mask_worn_better_vox.dmi
Binary file not shown.
Binary file added
BIN
+830 Bytes
modular_skyrat/modules/GAGS/icons/mask/masquerade_mask_worn_snouted.dmi
Binary file not shown.
Binary file added
BIN
+785 Bytes
modular_skyrat/modules/GAGS/icons/mask/masquerade_mask_worn_teshari.dmi
Binary file not shown.
Binary file added
BIN
+956 Bytes
modular_skyrat/modules/GAGS/icons/mask/masquerade_mask_worn_vox.dmi
Binary file not shown.
58 changes: 58 additions & 0 deletions
58
modular_skyrat/modules/GAGS/json_configs/masquerade_mask/masquerade_mask.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
{ | ||
"maskerade": [ | ||
{ | ||
"type": "icon_state", | ||
"icon_state": "mask", | ||
"blend_mode": "overlay", | ||
"color_ids": [ 1 ] | ||
} | ||
], | ||
"maskerade_two_colors": [ | ||
{ | ||
"type": "icon_state", | ||
"icon_state": "mask_left", | ||
"blend_mode": "overlay", | ||
"color_ids": [ 1 ] | ||
}, | ||
{ | ||
"type": "icon_state", | ||
"icon_state": "mask_right", | ||
"blend_mode": "overlay", | ||
"color_ids": [ 2 ] | ||
} | ||
], | ||
"maskerade_feather": [ | ||
{ | ||
"type": "icon_state", | ||
"icon_state": "mask", | ||
"blend_mode": "overlay", | ||
"color_ids": [ 1 ] | ||
}, | ||
{ | ||
"type": "icon_state", | ||
"icon_state": "mask_feather", | ||
"blend_mode": "overlay", | ||
"color_ids": [ 3 ] | ||
} | ||
], | ||
"maskerade_two_colors_feather": [ | ||
{ | ||
"type": "icon_state", | ||
"icon_state": "mask_left", | ||
"blend_mode": "overlay", | ||
"color_ids": [ 1 ] | ||
}, | ||
{ | ||
"type": "icon_state", | ||
"icon_state": "mask_right", | ||
"blend_mode": "overlay", | ||
"color_ids": [ 2 ] | ||
}, | ||
{ | ||
"type": "icon_state", | ||
"icon_state": "mask_feather", | ||
"blend_mode": "overlay", | ||
"color_ids": [ 3 ] | ||
} | ||
] | ||
} |
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+970 Bytes
(100%)
modular_skyrat/modules/better_vox/icons/clothing/hands.dmi
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+664 Bytes
(100%)
modular_skyrat/modules/better_vox/icons/clothing/helmet.dmi
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+32.4 KB
(100%)
modular_skyrat/modules/better_vox/icons/clothing/uniform.dmi
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
modular_skyrat/modules/customization/modules/clothing/masks/masquerade_mask.dm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
|
||
/obj/item/clothing/mask/masquerade | ||
name = "masquerade mask" | ||
desc = "You'll never guess who's under that mask, it's the perfect disguise!" | ||
icon_state = "maskerade" | ||
icon = 'modular_skyrat/modules/GAGS/icons/mask/masquerade_mask.dmi' | ||
worn_icon = 'modular_skyrat/modules/GAGS/icons/mask/masquerade_mask_worn.dmi' | ||
flags_1 = IS_PLAYER_COLORABLE_1 | ||
clothing_flags = MASKINTERNALS | ||
alternate_worn_layer = ABOVE_BODY_FRONT_HEAD_LAYER | ||
supports_variations_flags = CLOTHING_SNOUTED_VARIATION | CLOTHING_SNOUTED_VOX_VARIATION | CLOTHING_SNOUTED_BETTER_VOX_VARIATION | ||
greyscale_colors = "#ececec#333333#9b1e1e" | ||
greyscale_config = /datum/greyscale_config/masquerade_mask | ||
greyscale_config_worn = /datum/greyscale_config/masquerade_mask/worn | ||
greyscale_config_worn_muzzled = /datum/greyscale_config/masquerade_mask/worn/snouted | ||
greyscale_config_worn_better_vox = /datum/greyscale_config/masquerade_mask/worn/better_vox | ||
greyscale_config_worn_vox = /datum/greyscale_config/masquerade_mask/worn/vox | ||
greyscale_config_worn_teshari = /datum/greyscale_config/masquerade_mask/worn/teshari | ||
|
||
/obj/item/clothing/mask/masquerade/feathered | ||
name = "feathered masquerade mask" | ||
desc = "You'll never guess who's under that mask, it's the perfect disguise! This one even has a feather, to make it fancier!" | ||
icon_state = "maskerade_feather" | ||
|
||
/obj/item/clothing/mask/masquerade/two_colors | ||
name = "split masquerade mask" | ||
desc = "You'll never guess who's under that mask, it's the perfect disguise! There's even two colors, to add to the confusion!" | ||
icon_state = "maskerade_two_colors" | ||
|
||
/obj/item/clothing/mask/masquerade/two_colors/feathered | ||
name = "feathered split masquerade mask" | ||
desc = "You'll never guess who's under that mask, it's the perfect disguise! There's even two colors AND a feather, making it the most fancy masquerade mask yet!" | ||
icon_state = "maskerade_two_colors_feather" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.