add ethereum conversion function #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcppcp
reviewed
Dec 12, 2018
eth/web3.c
Outdated
|
|
||
| // add zeros | ||
| if (from >= to) { | ||
| set256_uint64(&power, pow(10, (int) from - (int) to)); |
There was a problem hiding this comment.
you can't really use pow() here since embedded systems can't use floats
There was a problem hiding this comment.
Since the custom pow function can't be built without using uint128_t (2 ^ 64 < 30) I used simple string manipulation for the eth_convert function, it's more efficient.
pcppcp
reviewed
Dec 13, 2018
eth/web3.c
Outdated
| return -1; | ||
| } | ||
| // move numbers | ||
| for (i = len + 1 + 1; i > len - shift; --i) { |
There was a problem hiding this comment.
One nitpick - could you replace magic numbers in string length calculation with defines? It will make it easier to read and understand.
i.e. here it would look like for (i = len + DECIMAL_POINT + SOMETHING; i > len - shift; --i)
Signed-off-by: Mislav Novakovic <[email protected]>
|
@pcppcp do you want me to do any other changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I implemented the
eth_convertfunction described in #97, I tried to use as much as possible the uint256_t functions, but now the code is a bit clunky and I'm not sure if I should simply convert the number to a string and simply add a.and move the number as strings around.Signed-off-by: Mislav Novakovic [email protected]