Implement zephyr system logger #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcppcp
reviewed
Oct 30, 2018
| @@ -11,6 +11,7 @@ | |||
| #include <zephyr.h> | |||
| #include <sensor.h> | |||
| #include <shell/shell.h> | |||
| #include <logging/sys_log.h> | |||
There was a problem hiding this comment.
now that I am checking the zephyr docs I see there're actually two (actually three) log systems:
- system log (CONFIG_SYS_LOG) https://docs.zephyrproject.org/1.12.0/subsystems/logging/system_log.html
- logger (CONFIG_LOG) https://docs.zephyrproject.org/latest/subsystems/logging/logger.html
logger seems to be better suited for our general logging, could you take a look at it? There're some examples in samples/subsys/logging.
There was a problem hiding this comment.
I implemented logger instead of system logger. What I should do now? New pull request?
There was a problem hiding this comment.
it's up to you; I usually squash the commits and force push to the branch, but opening a new PR is also ok :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UART logging: https://docs.zephyrproject.org/1.12.0/subsystems/logging/system_log.html
Using logging:
#include <logging/sys_log.h>
SYS_LOG_ERR
SYS_LOG_WRN
SYS_LOG_INF
SYS_LOG_DBG