Added "checks" before exporting project folders. Made changes in "Mesh2Input.py" #141
Conversation
During export of the project folder, if 3D print check- Check geometry is marked, the code will check for non-manifolds, intersections and sharp edges in the imported graded meshes. If there are any problems found, the project is not exported and the errors are reported in a text file called "Error_Checkall_info.txt" which is saved to the directory.
| checkall: BoolProperty( | ||
| name="3D-Print Checks", | ||
| description= ("Check geometry"), #Added by Sanket | ||
| default=True, | ||
| ) |
There was a problem hiding this comment.
- A general question: should we have separate checks or only one box that always does all checks?
- Lets find a different name for
checkallthis could be anything - Lets find a different name for '3D-Print checks' since Mesh2HRTF is not about printing
- The description should be more specific: What is checked for which mesh?
- There should not be any
#Added by Sanketor similar comments. Git keeps track of who added which code...
| @@ -200,6 +209,7 @@ def draw(self, context): | |||
| row.prop(self, "programPath") | |||
| row = layout.row() | |||
| row.prop(self, "pictures") | |||
| row.prop(self, "checkall") #Added by Sanket | |||
There was a problem hiding this comment.
In case we add separate parameters for different checks, this should get its own subcategory
| if checkall: | ||
| _write_checkall_txt(filepath1) #Added by Sanket | ||
|
|
There was a problem hiding this comment.
I would suggest to move this up, where we test for a triangular mesh. It might even make sense to include rthe triangular check only if the user wants to do the checks. Can you benchmark how long those checks take? This would help to decide if it would make sense to include separate parameters for different checks.
|
|
||
|
|
||
| #Added by Sanket | ||
| def _write_checkall_txt(filepath1): |
There was a problem hiding this comment.
Lets find a more descriptive function name (see comment on checkall above)
| #check edges are below the sharpness preference | ||
| bpy.ops.mesh.print3d_check_sharp() | ||
| info = report.info() | ||
| sharp_edge = info[0][0] | ||
| sharp_edge_num = int(re.search(r'\d+', sharp_edge).group()) |
There was a problem hiding this comment.
Sharp edges might indeed be a problem in the BEM. Wolfgang might have an idea about how critical this is. Can the threshold for reporting a sharp edge be set?
| file = open(os.path.join(filepath1, "Error_Checkall_info.txt"), "w", | ||
| encoding="utf8", newline="\n") |
There was a problem hiding this comment.
Any file operations should use the with statement. It makes sure that the file access is closed, even if an error occurs:
| file = open(os.path.join(filepath1, "Error_Checkall_info.txt"), "w", | |
| encoding="utf8", newline="\n") | |
| with open(os.path.join(filepath1, "Error_Checkall_info.txt"), "w", | |
| encoding="utf8", newline="\n") as file: | |
| file.write('text\n') |
Lets also think about a good filename.
| fw = file.write | ||
| # header -------------------------------------------------------------- | ||
| fw("##-------------------------------------------\n") | ||
| fw("## This file was created by mesh2input, export failed because of non-zero values during check-all\n") |
There was a problem hiding this comment.
This would be more illustrative. Maybe add line breaks for readibility:
| fw("## This file was created by mesh2input, export failed because of non-zero values during check-all\n") | |
| fw("## This file was created by the Mesh2HRTF export plug-in. The export failed because the Reference mesh might not be suitable for BEM computations. Try to fix the errors listed below or disable the checks if you are sure that the mesh can be used regardless of the errors.\n") |
| fw("## %s\n" % sharp_edge) | ||
| fw("##\n") | ||
| fw("##\n") | ||
| fw("Please make sure the object doesn't have non manifold edges/bad contiguous edges/intersect faces/sharp edges before export") |
There was a problem hiding this comment.
This line can be deleted if following the comment above
| fw("## %s\n" % bad_contiguous) | ||
| fw("## %s\n" % intersect_face) | ||
| fw("## %s\n" % sharp_edge) |
There was a problem hiding this comment.
Two suggestions:
- only write lines if there is a specific problem. E,g,:
if bad_contiguous: - It would be best if we gave hints on how to fix this. What would be best: add text here or link to the wiki, where we can add pictures?
During export of the project folder, if 3D print check- Check geometry is marked, the code will check for non-manifolds, intersections and sharp edges in the imported graded meshes. If there are any problems found, the project is not exported and the errors are reported in a text file called "Error_Checkall_info.txt" which is saved to the directory.