Prevent player movement when touch handler is holding an item

AntumDeluge · Dec 12, 2023 · b456739 · b456739
1 parent 3c9cc3c
commit b456739
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/srcjs/stendhal/ui/ViewPort.ts b/srcjs/stendhal/ui/ViewPort.ts
@@ -309,6 +309,10 @@ export class ViewPort {
 		mHandle._onMouseDown = function(e: MouseEvent|TouchEvent) {
 			var pos = stendhal.ui.html.extractPosition(e);
 			if (stendhal.ui.touch.isTouchEvent(e)) {
+				if (stendhal.ui.touch.holdingItem()) {
+					// prevent default viewport action when item is "held"
+					return;
+				}
 				stendhal.ui.touch.onTouchStart(pos.pageX, pos.pageY);
 			}
 			if (stendhal.ui.globalpopup) {
@@ -369,6 +373,7 @@ export class ViewPort {
 						new ActionContextMenu(entity, append), pos.pageX - 50, pos.pageY - 5));
 				}
 			} else if (stendhal.ui.touch.holdingItem()) {
+				// FIXME: this may be unnecessary
 				stendhal.ui.gamewindow.onDrop(e);
 			} else {
 				entity.onclick(pos.canvasRelativeX, pos.canvasRelativeY);