chore: Streamline option checking in arch-update.conf #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamline option checking in the `arch-update.conf` configuration file by optimizing the way each option are checked and the way the related variables are set.
… default/fallback value for options that require it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Streamline option checking in the
arch-update.confconfiguration file by optimizing the way each option are checked and the way the related variables are set:lib/config.shis now dedicated to checking options set inarch-update.confarch-update.conffile is found/existsgrep(instead of running grep twice; once to check the validity of the set value and once to affiliate the value with the variable).