Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dark and blue variants to the systray icon set and add the "TrayIconStyle" option in arch-update.conf #242

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

hunabku94
Copy link
Contributor

@hunabku94 hunabku94 commented Sep 25, 2024

Description

Add the following style/color variants to the systray applet icon set:

  • dark (Useful to make the systray applet icon more visible when using a light theme)
  • blue (Matches the blue variant used by the official Arch Linux logo)

Add the TrayIconStyle option in the arch-update.conf configuration file to select which icon style/color variants to use (e.g. TrayIconStyle=dark).
Defaults to light.

Screenshots / Logs

Light (classic) variant:

2024-09-25_12-48

image

Dark variant:

2024-09-25_12-50

image

Blue variant:

image

image

Addressed feature request

Closes #240

hunabku94 and others added 5 commits September 25, 2024 11:30
…"TrayIconStyle" option in arch-update.conf

Add the following style/color variants to the systray applet icon set:

- dark (Useful to make the systray applet icon more visible when using a light theme)
- blue (Matches the blue variant used by the official Arch Linux logo)

Add the `TrayIconStyle` option in the `arch-update.conf` configuration file to select which icon style/color variants to use (e.g. `TrayIconStyle=dark`).
Defaults to `light`.

Closes #240
Copy link
Owner

@Antiz96 Antiz96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!
That's a really nice addition 😄

@Antiz96 Antiz96 added this to the v3.1.0 milestone Sep 25, 2024
@Antiz96 Antiz96 changed the title Add dark and blue color version icons @Antiz96 feat: Add dark and blue variants to the systray icon set and add the "TrayIconStyle" option in arch-update.conf Sep 25, 2024
@Antiz96 Antiz96 changed the title @Antiz96 feat: Add dark and blue variants to the systray icon set and add the "TrayIconStyle" option in arch-update.conf feat: Add dark and blue variants to the systray icon set and add the "TrayIconStyle" option in arch-update.conf Sep 25, 2024
@Antiz96 Antiz96 merged commit 7be96c7 into Antiz96:main Sep 25, 2024
1 check passed
@Antiz96
Copy link
Owner

Antiz96 commented Sep 25, 2024

With the changes added in this pull request, it should be relatively easy to add new additional style/color variants for the systray icon!

If anyone passing by is interested to contribute new style/color variants for the systray icon, you can open a pull request including the following changes:

1 - Copy the arch-update-light.svg & the arch-update_updates-available-light.svg files (which are under src/icons) and update the name suffix to match your new style/color variant (e.g. for a yellow variant: arch-update-yellow.svg & the arch-update_updates-available-yellow.svg).

2 - Modify the value of the fill: parameter with the hex color code that matches your new style/color variant in both files (do not update the value of the second fill: parameter in the arch-update_updates-available-*.svg file, as this is one is for the red circle that shows up when there are new available updates).

3 - Update the list of valid values for the TrayIconStyle option in the src/lib/config.sh file with your new style/color variant (e.g. for a yellow variant: [...](light|dark|blue|yellow)[...]).

That's it!
Once the changes are merged and released, everyone will be able to use your new style/color variant via the TrayIconStyle option in the arch-update.conf configuration file (e.g. for a yellow variant: TrayIconStyle=yellow). 🎨

@Antiz96 Antiz96 mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Tray Icon
2 participants