Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(news): Make curl fail on http server errors responses when checking for recent news #220

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

Antiz96
Copy link
Owner

@Antiz96 Antiz96 commented Jul 20, 2024

Description

This commit makes curl fail on http server errors response (e.g. archlinux.org is down or under huge loads, responding http error code 504, 502, etc...).
This is to prevent getting wrongly formatted news list in such scenarios, resulting in an unexpected error and incorrectly formatted news display.

Screenshots / Logs

==> Arch News:
/usr/bin/arch-update: line 388: [: : integer expression expected
1 - 

…ng for recent news

This commit makes curl fail on http server errors response (e.g. archlinux.org is down or under huge loads, responding http error code 504, 502, etc...).
This is to prevent getting wrongly formatted news list in such scenarios, resulting in an unexpected error and incorrectly formatted news display.
@Antiz96 Antiz96 added this to the v2.3.1 milestone Jul 20, 2024
Copy link
Owner Author

@Antiz96 Antiz96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antiz96 Antiz96 merged commit 384b6bc into main Jul 20, 2024
1 check passed
@Antiz96 Antiz96 deleted the curl_fail branch July 20, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant