Replace the previously sent desktop notification instead of sending a new one during the check function #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the current notification behavior by replacing the previously sent desktop notification (instead of sending a new one) during the check function, to avoid having notifications stacking over time if they are not cleared.
With this new behavior, Arch-Update will send new notifications by replacing the ID of the previous one, acting as an "update" of the previously sent notification instead of simply sending a new one. Thanks to this, Arch-Update will only show one (and only one) notification in the notification history/center (being updated on the fly if needed).
Of course, when a notification is being updated (if there is a new update available), it is still pushed/shown to the user just like if a new one has been sent.
Closes #133