Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display Arch news if a new one has been published since the last run #115

Merged
merged 7 commits into from
Feb 25, 2024

Conversation

Antiz96
Copy link
Owner

@Antiz96 Antiz96 commented Feb 22, 2024

This PR aims to makes Arch news displaying more relevant by only displaying them if at least a new one had been published since the last arch-update run (instead of being displayed systematically, which is irrelevant/useless most of the time).

Arch news published since the last run are tagged as [NEW].

One can still use the 'old' behavior (always display Arch news before updating, regardless of whether there's a new one since the last run or not), by setting the AlwaysShowNews option in arch-update.conf.

With this new behavior, the NoNews option (suggested in #85 and introduced in #89) is deprecated and completely removed since it's not relevant anymore.

Closes #110

@Antiz96 Antiz96 self-assigned this Feb 22, 2024
@Antiz96 Antiz96 added the feature/request New feature or request label Feb 22, 2024
@Antiz96 Antiz96 added this to the v1.12.0 milestone Feb 22, 2024
@Antiz96 Antiz96 marked this pull request as ready for review February 25, 2024 22:08
Copy link
Owner Author

@Antiz96 Antiz96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antiz96 Antiz96 merged commit 1ee586e into main Feb 25, 2024
1 check passed
@Antiz96 Antiz96 deleted the only_new_news branch February 25, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only print Arch news if there's a new one compared to the last run
1 participant