Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Flatpak packages updates detection more robust to avoid false positives #104

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Antiz96
Copy link
Owner

@Antiz96 Antiz96 commented Feb 7, 2024

This commit aims to make the Flatpak updates detection more robust by filtering the 'flatpak update' command output to remove everything placed before the listing of available updates.
This avoid potential false positives in Arch-Update's listing as it ensure that everything placed above the listing of available updates in the 'flatpak update' output will not be included in the list (such as info, warning, etc...).

The complete output is still shown when the Flatpak updates are actually applied during the script, so users are still aware of potential info/warnings.

Fixes #103

…sitives

> This commit aims to make the Flatpak updates detection more robust by filtering the 'flatpak update' command output to remove everything placed before the listing of available updates.
> This avoid potential false positives in Arch-Update's listing as it ensure that everything placed above the listing of available updates in the 'flatpak update' output will not be included in the list (such as info, warning, etc...).
>
> The complete output is still shown when the Flatpak updates are actually applied during the script, so users are still aware of potential info/warnings.
>
> Fixes #103
@Antiz96 Antiz96 added this to the v1.11.0 milestone Feb 7, 2024
Copy link
Owner Author

@Antiz96 Antiz96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antiz96 Antiz96 merged commit 5546c83 into main Feb 7, 2024
1 check passed
@Antiz96 Antiz96 deleted the fix_flatpak_packages_updates_detection branch February 7, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong return for flatpaks packages when an app uses an outdated runtime
1 participant