Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.2 -> main] P2P: Resolve on reconnect - Take 2 #868

Merged
merged 10 commits into from
Oct 2, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 2, 2024

Resolve address on reconnect. (Take 2, See #825)

Instead of:

info  2024-09-25T21:50:50.686 net-1     net_plugin.cpp:2797           operator()           ] connection failed to p2p.telos-bad.zenblocks.io:9876, Element not found
info  2024-09-25T21:50:50.686 net-1     net_plugin.cpp:1461           _close               ] ["p2p.telos-bad.zenblocks.io:9876" - 1 <unknown>:<unknown>] closing

Now you get:

warn  2024-09-25T21:42:48.642 net-0     net_plugin.cpp:4524           operator()           ] Unable to resolve p2p.telos-bad.zenblocks.io:9876 Host not found (authoritative)

This takes a different approach than #825. This approach is closer to Leap 4.0 approach to connection lifetime although it does keep the connections_manager added in Leap 5.0.

Backported to Leap 5.0 via AntelopeIO/leap#2410

Merges release/1.0 into main including #853

Resolves #525

@heifner heifner added the OCI Work exclusive to OCI team label Oct 2, 2024
@heifner heifner linked an issue Oct 2, 2024 that may be closed by this pull request
Base automatically changed from gh_778_main to main October 2, 2024 15:59
@heifner heifner marked this pull request as draft October 2, 2024 17:01
@spoonincode
Copy link
Member

Need to take this out of draft and take it otherwise there is no way to merge up from 1.0 properly

@spoonincode spoonincode marked this pull request as ready for review October 2, 2024 17:48
@spoonincode spoonincode merged commit 80ad6d6 into main Oct 2, 2024
34 of 36 checks passed
@spoonincode spoonincode deleted the GH-525-p2p-resolve-main branch October 2, 2024 17:49
@heifner heifner changed the title [1.0.2 -> main] P2P: Resolve on reconnect [1.0.2 -> main] P2P: Resolve on reconnect - Take 2 Oct 2, 2024
@ericpassmore ericpassmore added the bug The product is not working as was intended. label Oct 3, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: P2P
summary: Improve peer connections with more robust endpoint resolution on reconnection.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended. OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2P: Resolve endpoints on re-connect attempts
4 participants