[1.0.2 -> main] Don't assume that claimed block is in fork_db. #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…just claimed block.
…assert not always true)
…tors are as well.
…in another branch)
[1.0.2] Don't assume that claimed block is in fork_db.
heifner
approved these changes
Oct 2, 2024
linh2931
approved these changes
Oct 2, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #778 and #751.
Update fork_db_validated_block_exists to lookup parents instead of just claimed block.
Also updated the validated member in both block_state_legacy and block_state to be copyable_atomic instead of bool, which allowed to make the set_valid() and is_valid() members public, and thus eliminate a couple of friend declarations.
Also adds testcase described in issue #751.