add manually run workflow to exhaustively test all LLVM versions expected to work #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Oct 1, 2024
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| version: ['10.0.1', '11.1.0'] |
There was a problem hiding this comment.
But wait, if we expect 7 through 11 to work why is this new workflow only testing 10 and 11? ah yes, tune in soon for the next PR...
spoonincode
commented
Oct 1, 2024
| cmake -S src -B build -DCMAKE_BUILD_TYPE=Release -GNinja | ||
| cmake --build build | ||
| - name: Test spring | ||
| run: ctest --test-dir build -j $(nproc) --output-on-failure -LE "(nonparallelizable_tests|long_running_tests)" -E eosvmoc_limits_unit_test_eos-vm-oc --timeout 480 |
There was a problem hiding this comment.
The eosvmoc_limits_unit_test is very sensitive to exact code generated since its pass criteria was empirically derived from a single LLVM version with a threshold of 1 byte. Need to think on how to improve this test; disable in here for now.
linh2931
approved these changes
Oct 2, 2024
heifner
approved these changes
Oct 2, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring is expected to build with LLVM versions 7 through 11. As #578 is worked this range of versions will change to include newer versions. I'd like to have a way to demonstrate that newer versions do indeed compile and test successfully beyond "trust me bro".
So add a simple manually dispatched workflow that compiles with all supported LLVM major versions. This seems like a good enough tradeoff over doing something vastly more complex in CI, and I certainly do not want this to run on every PR. The main risk I see is that since this workflow is disparate to the primary per-PR build workflow it can potentially get out of date; such as the build dependencies or
cmake/ctestarguments going stale. I feel like that's an acceptable risk at the moment.A run of this workflow can be found here,
https://github.com/AntelopeIO/spring/actions/runs/11132990881