[1.0.2] Fix reported time for produced blocks and fix confusing reported time name #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Oct 1, 2024
heifner
approved these changes
Oct 1, 2024
greg7mdp
approved these changes
Oct 1, 2024
| @@ -3459,7 +3459,7 @@ struct controller_impl { | |||
| fc::time_point now = fc::time_point::now(); | |||
|
|
|||
| ilog("Produced block ${id}... #${n} @ ${t} signed by ${p} " | |||
| "[trxs: ${count}, lib: ${lib}${confs}, net: ${net}, cpu: ${cpu}, elapsed: ${et} us, time: ${tt} us]", | |||
| "[trxs: ${count}, lib: ${lib}${confs}, net: ${net}, cpu: ${cpu} us, elapsed: ${et} us, producing time: ${tt} us]", | |||
There was a problem hiding this comment.
I'm not sure how a user would understand the difference between elapsed and producing time?
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
timefor "Produced blocks" toproducing time, and for "Received blocks" toapplying timeusto reported CPU timeBefore the changes
info 2024-10-01T18:31:59.066 nodeos controller.cpp:3462 commit_block ] Produced block dd7794184632fdd2... #100 @ 2024-10-01T18:31:59.500 signed by eosio [trxs: 0, lib: 98, net: 0, cpu: 100, elapsed: 342 us, time: 1727797983669080 us]After
info 2024-10-01T19:07:27.667 nodeos controller.cpp:3461 commit_block ] Produced block b29e040564b322f2... #100 @ 2024-10-01T19:07:28.000 signed by eosio [trxs: 0, lib: 98, net: 0, cpu: 100 us, elapsed: 291 us, producing time: 451393 us]Fix #849