[1.0 -> main] Improve finalizer safety file exception handling #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save_finalizer_safety_info()
to never throw, but instead to log and returnfalse
.bls_signature
can throw on invalid signature. Not exactly sure if that is possible inmaybe_vote
, but seems like if the private key is invalid somehow it might be possible. Added a try-catch-log-and-drop so an exception there does not kill the thread pool.set_default_safety_information()
is only called at startup or during initial transition to savanna when no votes should be flowing. But doesn't hurt and easier to have it than to prove it is not needed.Example error when unable to open
safety.dat
file.Merges
release/1.0
intomain
including #659#646 appears to have been resolved by #624. This PR is addressing better exception handling related to #646.
Resolves #646