[1.0] various different signedness warning fixes #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Aug 23, 2024
spoonincode
commented
Aug 23, 2024
| @@ -233,7 +233,7 @@ BOOST_AUTO_TEST_CASE(snapshot_scheduler_old_json) { | |||
| unsigned found = 0; | |||
| for(const std::filesystem::directory_entry& dir_entry : std::filesystem::directory_iterator(temp / "snapshots")) | |||
| found += std::regex_search(dir_entry.path().filename().string(), snapshotfile_regex); | |||
| BOOST_REQUIRE_GE(found, 3); | |||
| BOOST_REQUIRE_EQUAL(found, 3u); | |||
There was a problem hiding this comment.
The test was originally more sloppy and it's why it was >=3; I forgot to change this to ==3 after making it more strict. Not a big enough deal to go back to 5.0 to fix this imo
heifner
requested changes
Aug 23, 2024
heifner
approved these changes
Aug 23, 2024
greg7mdp
approved these changes
Aug 23, 2024
|
ah crud sorry I got way to trigger happy and forgot to merge in chainbase first |
This was referenced Aug 23, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grabbag of different signedness warning fixes I noticed. I'm fine sending these to main instead, but most/all of these were introduced at the 11th hour before cutting 1.0.0 rc
Needs AntelopeIO/chainbase#53