[1.0] Add test case to demonstrate the weak masking issue #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Aug 24, 2024
heifner
requested changes
Aug 24, 2024
heifner
approved these changes
Aug 24, 2024
|
Note:start |
|
nice ascii graph in unittests/savanna_misc_tests.cpp |
linh2931
approved these changes
Aug 26, 2024
| // ------------------- | ||
| void print(const char* name, const signed_block_ptr& b) const { | ||
| if (_debug_mode) | ||
| std::cout << name << " ts = " << b->timestamp.slot << ", id = " << b->calculate_id().str().substr(8, 16) |
There was a problem hiding this comment.
As this is in debug mode, you can just print out the whole ID.
There was a problem hiding this comment.
I missed this cout, use ilog and then you can enable via unittest -- --verbose and you don't need the _debug_mode.
There was a problem hiding this comment.
I actually like this better because I print only what is relevant for the test.
| BOOST_FIXTURE_TEST_CASE(weak_masking_issue, savanna_cluster::cluster_t) try { | ||
| auto& A=_nodes[0]; auto& B=_nodes[1]; auto& C=_nodes[2]; auto& D=_nodes[3]; | ||
| using vote_t = savanna_cluster::node_t::vote_t; | ||
| //_debug_mode = true; |
There was a problem hiding this comment.
Remove this commented out line.
There was a problem hiding this comment.
I like having it here personally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #544.
Branch
gh_544_checkcreated off commit 7beaa20 prior to PR #537 (implementing the FSI changes to avoid the issue) has the new test failing.