Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0 -> main] Replay from retained directory with no block log #597

Merged
merged 15 commits into from
Aug 20, 2024
Merged

[1.0 -> main] Replay from retained directory with no block log #597

merged 15 commits into from
Aug 20, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 20, 2024 •
edited
Loading

PR fixes two issues:

  • Replaying from a snapshot with no block log, but blocks in the retained directory, issue Loading from snapshot with block strides #586
    • Before this PR, block log head would be nullptr and no blocks would be replayed from the retained directory.
  • Interrupting replay of block log (from blocks or retained directory) via ctrl-c, restarting replay when no fork database.
    • Before this PR, would fail by throwing an error that no fork database exists.

Merges release/1.0 into main including #565 and #595 (forward backport back to main)

Resolves #586

greg7mdp and others added 15 commits August 20, 2024 08:30
@greg7mdp
Add new test policy_change_including_weight_and_threshold
864c9c7
@greg7mdp
Add new testcase policy_change_reduce_threshold_replace_all_keys
c9ac6fa
@greg7mdp
Add new testcase policy_change_restart_from_snapshot
3fdb754
@greg7mdp
Automatic sync blocks on node startup.
315ebcf
@greg7mdp
Fix typo.
0e82108
@greg7mdp
Merge branch 'release/1.0' of github.com:AntelopeIO/spring into gh_38…
183ff37 
…0_1.0
@heifner
GH-586 Move snapshotted_tester to header file for reuse in partitione…
e5c98c3 
…d_block_log_tests
@heifner
GH-586 If no head in block log, attempt to read from partitioned catalog
acc75eb
@heifner
GH-586 Allow for no forkdb if replay of block log stopped via ctrl-c
effe229
@heifner
GH-586 Add tests for replaying from snapshot or from no block log wit…
722772c 
…h blocks in the retained dir.
@heifner
GH-586 Remove dead code
7c6dc59
@heifner
GH-586 Avoid two chains using the same oc code cache
c33b3d7
@greg7mdp
Merge pull request #595 from AntelopeIO/gh_380_1.0
3323898 
[main -> 1.0] Implement last three Savanna unittests modeled after the fast testnet wave tests.
@heifner
Merge pull request #596 from AntelopeIO/GH-586-no-block-log-with-reta…
05ffa5d 
…ined

[1.0] Replay from retained directory with no block log
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-586-no-bloc…
efcc998 
…k-log-with-retained-main
@heifner heifner requested review from greg7mdp and arhag August 20, 2024 17:03
@heifner heifner added the OCI Work exclusive to OCI team label Aug 20, 2024
@arhag arhag linked an issue Aug 20, 2024 that may be closed by this pull request
Create Savanna unittests modeled after the fast testnet wave tests. #380
Closed
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Replay from Blocks in the retained directory.
Note:end

@heifner heifner merged commit b3a74eb into main Aug 20, 2024
36 checks passed
@heifner heifner deleted the GH-586-no-block-log-with-retained-main branch August 20, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading from snapshot with block strides Create Savanna unittests modeled after the fast testnet wave tests.
4 participants
@heifner @ericpassmore @greg7mdp @arhag