Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove final_on_strong_block_num from code base #411

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Remove final_on_strong_block_num from code base #411

merged 3 commits into from
Jul 26, 2024

Conversation

linh2931
Copy link
Member

Remove final_on_strong_qc_block_num from the code. Use latest_qc_claim().block_num instead where final_on_strong_qc_block_num was used.

Resolve #385

@linh2931 linh2931 requested review from greg7mdp and heifner July 26, 2024 02:01
@linh2931 linh2931 merged commit 21bb5e9 into main Jul 26, 2024
36 checks passed
@linh2931 linh2931 deleted the remove_final_on_strong branch July 26, 2024 13:09
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Use lastest_qc_claim block_num in block header.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up: Remove final_on_strong_qc_block_num
4 participants
@linh2931 @ericpassmore @greg7mdp @heifner