Use 2-chain for finality #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts for number of chains required for a block to become final
…new_finality_digest
heifner
added
the
consensus-protocol
heifner
approved these changes
Jul 23, 2024
systemzax
approved these changes
Jul 23, 2024
|
Note:start |
greg7mdp
reviewed
Jul 24, 2024
unittests/finality_tests.cpp
Outdated
| // ------------------------------------------------------------------------------- | ||
| for (size_t i=0; i<3; ++i) { | ||
| for (size_t i=0; i<(num_chains_to_final - 1); ++i) { |
There was a problem hiding this comment.
If we need a 2-chain, why num_chains_to_final - 1. Also the comment at line 733 above is incorrect, we won't have three pending policies at the same time.
There was a problem hiding this comment.
Fixed it by c1feb76
Thanks.
| t.check_head_finalizer_policy(1u, pubkeys0); // one 3-chain - new policy still should not be active | ||
|
|
||
| t.produce_blocks(2); | ||
| t.produce_blocks(num_chains_to_final-1); | ||
| t.check_head_finalizer_policy(1u, pubkeys0); // one 3-chain + 2 blocks - new policy still should not be active |
There was a problem hiding this comment.
comment is wrong, it should be + 1 block
There was a problem hiding this comment.
It's decided the comments in the remaining files to be fixed later. Tracked by #398
| @@ -101,8 +101,8 @@ BOOST_AUTO_TEST_CASE(savanna_set_finalizer_multiple_test) { try { | |||
| auto pubkeys2 = fin_keys.set_finalizer_policy(2u).pubkeys; | |||
| t.produce_block(); | |||
| t.check_head_finalizer_policy(1u, pubkeys0); // new policy should only be active until after two 3-chains | |||
There was a problem hiding this comment.
many comments in this file still mention 3-chains. Some in other files as well.
| b = t.produce_block(); // pending: pubkeys5, proposed: pubkeysr6, pubkeys7, pubkeys8, pubkeys9 | ||
| verify_block_finality_policy_diff(b, 9, pubkeys9.back()); | ||
| auto pubkeys10 = fin_keys.set_finalizer_policy(10u).pubkeys; | ||
| t.check_head_finalizer_policy(3u, pubkeys3); // 7 blocks after pubkeys4, pubkeys4 should still be active | ||
| t.check_head_finalizer_policy(5u, pubkeys5); // 7 blocks after pubkeys4, pubkeys4 should still be active |
There was a problem hiding this comment.
comment is clearly incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finality_coreto use two-chain for finality.get_new_block_numbers().Resolves #384