Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta1 -> main] Vote processing fix #159

Merged
merged 6 commits into from
May 17, 2024
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented May 17, 2024

  • Do not post to vote thread pool if thread pool is not active.
    • This fixes a memory leak when there are no vote threads; which is why the original PR was targeted to 1.0-beta1 instead of main
  • A producer should notify vote processor that it has produced a block
  • Update the tester wait on votes to be consistent

Merges release/1.0-beta1 into main including #158

Resolves #139
Resolves #143

@heifner heifner added the OCI Work exclusive to OCI team label May 17, 2024
@heifner heifner merged commit 5ababa5 into main May 17, 2024
36 checks passed
@heifner heifner deleted the GH-139-vote-not-received-main branch May 17, 2024 19:35
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: BUG
summary: Ensure votes are posted to an existing vote thread pool. Fixes a memory leak when there are no vote threads.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failure: finality_unit_test_eos-vm-jit Test Failure: svnn_ibc_unit_test_eos-vm-jit
4 participants