Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safety.dat unable to SEEK_SET to 0 #646

Closed
heifner opened this issue Aug 27, 2024 · 2 comments · Fixed by #659 or #663
Closed

safety.dat unable to SEEK_SET to 0 #646

heifner opened this issue Aug 27, 2024 · 2 comments · Fixed by #659 or #663
Assignees
@heifner
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.0.0-rc3

Comments

@heifner
Copy link
Member

heifner commented Aug 27, 2024 •
edited
Loading

Noticed in log of lib_advance_test.py

This was before #624
https://github.com/AntelopeIO/spring/actions/runs/10564544450

warn  2024-08-26T18:00:00.910 net-1     finalizer.cpp:209             save_finalizer_safet ] 13 NSt8ios_base7failureB5cxx11E: cfile: /__w/spring/spring/build/TestLogs/lib_advance_test9/node_03/finalizers/safety.dat unable to SEEK_SET to: 0, ferror: 0: iostream error
rethrow cfile: /__w/spring/spring/build/TestLogs/lib_advance_test9/node_03/finalizers/safety.dat unable to SEEK_SET to: 0, ferror: 0: iostream error: 
    {"what":"cfile: /__w/spring/spring/build/TestLogs/lib_advance_test9/node_03/finalizers/safety.dat unable to SEEK_SET to: 0, ferror: 0: iostream error"}
    net-1  finalizer.cpp:209 save_finalizer_safety_info
@heifner heifner added this to the Spring v1.0.0-rc3 milestone Aug 27, 2024
@heifner heifner added bug The product is not working as was intended. and removed triage labels Aug 27, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 27, 2024
@heifner heifner added the triage label Aug 27, 2024
@bhazzard
Copy link

bhazzard commented Aug 27, 2024 •
edited
Loading

For RC3: catch and stop voting, possibly shut down.

Finding the root cause of the SEEK_SET error could become a separate issue tracked for a future milestone (after v1.0.0).

@bhazzard bhazzard added 👍 lgtm OCI Work exclusive to OCI team and removed triage labels Aug 27, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Aug 27, 2024
heifner added a commit that referenced this issue Aug 28, 2024
@heifner
GH-646 Modify save_finalizer_safety_info() to not throw. Only send ou…
446c959 
…t and incorporate vote if save_finalizer_safety_info() returns true.

Add missing mutex. Unlikely needed as only accessed during startup or initial transition.
Throw exception out of load_finalizer_safety_info() if unable to open file.
@heifner heifner mentioned this issue Aug 28, 2024
Merged
heifner added a commit that referenced this issue Aug 28, 2024
@heifner
GH-646 Add try-catch-log-and-drop on bls_signature creation to avoid …
67c9256 
…an exception killing the thread pool
heifner added a commit that referenced this issue Aug 28, 2024
@heifner
GH-646 Update has_voted even if unable to save safety file
e35bb63
@heifner
Copy link
Member Author

heifner commented Aug 28, 2024

Was able to reproduce this issue on branch f866521, but not on branch 5315ce6. Appears to have been fixed by #624 somehow. Unclear as nothing in #624 should have made any difference in this regard.

@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Aug 28, 2024
heifner added a commit that referenced this issue Aug 28, 2024
@heifner
Merge pull request #659 from AntelopeIO/GH-646-safety-file-exceptions
c3b7615 
[1.0] Improve finalizer safety file exception handling
heifner added a commit that referenced this issue Aug 28, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-646-safety-…
3b0dce3 
…file-exceptions-main
@heifner heifner mentioned this issue Aug 28, 2024
Merged
heifner added a commit that referenced this issue Aug 28, 2024
@heifner
Merge pull request #663 from AntelopeIO/GH-646-safety-file-exceptions…
4b76e91 
…-main

[1.0 -> main] Improve finalizer safety file exception handling
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Spring v1.0.0-rc3
3 participants
@bhazzard @heifner @enf-ci-bot