Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace final_on_strong_qc_block_num in finality digest calculation and instead add other needed data #386

Closed
arhag opened this issue Jul 19, 2024 · 0 comments · Fixed by #397
Assignees
Labels
consensus-protocol Change to the consensus protocol. Impacts light client validation. 👍 lgtm

Comments

@arhag
Copy link
Member

arhag commented Jul 19, 2024

Depends on #377.

Remove final_on_strong_qc_block_num from finality_digest_data_v1.

Then add the following into level_3_commitments:

  • latest_qc_claim_block_num
  • latest_qc_claim_finality_digest
  • latest_qc_claim_timestamp
  • timestamp: This is the timestamp of the current block.

Also remove final_on_strong_qc_block_num from finality_data and instead add latest_qc_claim_block_num, latest_qc_claim_finality_digest, and latest_qc_claim_timestamp to finality_data.

@arhag arhag added this to the Savanna: Production-Ready milestone Jul 19, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jul 19, 2024
@arhag arhag added consensus-protocol Change to the consensus protocol. Impacts light client validation. 👍 lgtm and removed triage labels Jul 19, 2024
@linh2931 linh2931 self-assigned this Jul 23, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Jul 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus-protocol Change to the consensus protocol. Impacts light client validation. 👍 lgtm
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants