Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up: Remove final_on_strong_qc_block_num #385

Closed
arhag opened this issue Jul 19, 2024 · 0 comments · Fixed by #411
Closed

Clean up: Remove final_on_strong_qc_block_num #385

arhag opened this issue Jul 19, 2024 · 0 comments · Fixed by #411
Assignees
@linh2931
Labels
consensus-protocol Change to the consensus protocol. Impacts light client validation. 👍 lgtm
Milestone
Savanna: Cusp

Comments

@arhag
Copy link
Member

arhag commented Jul 19, 2024 •
edited
Loading

Depends on #384 and #386.

Use latest_qc_claim().block_num instead everywhere that final_on_strong_qc_block_num was used. Remove final_on_strong_qc_block_num from the code.
@arhag arhag added this to the Savanna: Cusp milestone Jul 19, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jul 19, 2024
@arhag arhag added consensus-protocol Change to the consensus protocol. Impacts light client validation. and removed triage labels Jul 19, 2024
@linh2931 linh2931 self-assigned this Jul 25, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Jul 25, 2024
@linh2931 linh2931 mentioned this issue Jul 26, 2024
Merged
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Jul 26, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
consensus-protocol Change to the consensus protocol. Impacts light client validation. 👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Savanna: Cusp
Development

Successfully merging a pull request may close this issue.

Remove final_on_strong_block_num from code base AntelopeIO/spring
3 participants
@arhag @linh2931 @enf-ci-bot