Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Update BIOS finality tests to use base64url encoded BLS keys and signatures #56

Merged
merged 2 commits into from
Feb 27, 2024
Merged

IF: Update BIOS finality tests to use base64url encoded BLS keys and signatures #56

merged 2 commits into from
Feb 27, 2024

Conversation

linh2931
Copy link
Member

Change Description

Leap PR AntelopeIO/leap#2255 changes BLS keys and signatures to base64 url format. Existing tests in BIOS finality use regular base64 format. Update the tests to use base64 URL format.

Deployment Changes

  • Deployment Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@linh2931 linh2931 merged commit 1049b2c into instant-finality Feb 27, 2024
1 check passed
@linh2931 linh2931 deleted the new_base64_encoding branch February 27, 2024 02:36
@linh2931 linh2931 mentioned this pull request Feb 27, 2024
Merged
3 tasks
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Easier to use BLS key format. Matches leap implementation.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoonincode spoonincode spoonincode approved these changes

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@linh2931 @ericpassmore @greg7mdp @heifner @spoonincode