only use ENF runners for builds in AntelopeIO Leap repository #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
changed the title
|
Should we close this PR as superseded by PR #1710 |
|
It wasn't superseded by 1710, but this PR is grossly out of date and would require significant modifications to get it ready again. I think maybe we just close it out for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the great strengths with Github Actions is that a user can fork a public repository and inherit a fully operational CI pipeline they can use for free on their public fork.
But that doesn't work for Leap currently because the workflow requires use of ENF runners which of course no other fork can utilize. Since we only use ENF runners for speed (Github's free runners do build the software as expected, afaik), let's only use ENF runners for builds in the AntelopeIO org. Forks will use Github's free runners.
Is there a better way to do this? Maybe only check the string once in the
djob and reference a boolean elsewhere?