Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Integration tests enabled for instant-finality (Part 2) #2166

Merged
merged 22 commits into from
Jan 31, 2024
Merged

IF: Integration tests enabled for instant-finality (Part 2) #2166

merged 22 commits into from
Jan 31, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 30, 2024 •
edited
Loading

Adding additional integration tests for instant-finality

  • nodeos_retry_transaction_if_lr_test
  • nodeos_run_if_test
  • nodeos_short_fork_take_over_if_test
  • nodeos_snapshot_diff_if_test (disabled) requires IF: Add new snapshot version to hold consensus Savanna state #1558
  • nodeos_snapshot_forked_if_test
  • nodeos_under_min_avail_ram_lr_test modified to run only under instant-finality (shouldn't make any difference)
  • nodeos_voting_if_lr_test
  • p2p_multiple_listen_if_test
  • p2p_sync_throttle_if_test
  • read-only-trx-basic-if-test
  • read-only-trx-parallel-if-test
  • read-only-trx-parallel-eos-vm-oc-test modified to run only under instant-finality
  • read-only-trx-parallel-no-oc-test modified to run only under instant-finality
  • restart-scenarios-if-test-resync
  • restart-scenarios-if-test-hard_replay (disabled) requires IF: replay from before instant-finality transition #2141
  • restart-scenarios-if-test-none
  • subjective_billing_test modified to run only under instant-finality
  • terminate-scenarios-if-test-resync
  • terminate-scenarios-if-test-replay (disabled) requires IF: replay from before instant-finality transition #2141
  • terminate-scenarios-if-test-hard_replay
  • trace_plugin_test modified to run only under instant-finality
  • trx_finality_status_forked_if_test
  • trx_finality_status_if_test
  • ship_streamer_if_test (disabled) requires IF: investigate and fix ship_streamer_if_test #2172

@heifner heifner added the OCI Work exclusive to OCI team label Jan 30, 2024
@heifner
GH-1510 Add - read-only-trx-basic-if-test
6f29dce 
            - read-only-trx-parallel-if-test
            - read-only-trx-parallel-eos-vm-oc-test modified to run under instant-finality
            - read-only-trx-parallel-no-oc-test modified to run under instant-finality
@heifner
GH-1510 Add - restart-scenarios-if-test-resync
d980a43 
            - restart-scenarios-if-test-hard_replay (disabled) requires GH-2141
            - restart-scenarios-if-test-none
@heifner
GH-1510 Add ship_if_test
6ebb398
@heifner
GH-1510 Fix spelling
ea78afe
@heifner
GH-1510 subjective_billing_test.py modified to run under instant-fina…
ea00b40 
…lity
@heifner
Merge branch 'merge-main-01-31-2024' into GH-1510-integration-if-tests
a2ef2e2
@heifner
GH-1510 Add - terminate-scenarios-if-test-resync
76fe85f 
            - terminate-scenarios-if-test-replay (disabled) requires #2141
            - terminate-scenarios-if-test-hard_replay
@heifner
GH-1510 trace_plugin_test.py run under instant-finality
4744630
@heifner
GH-1510 Add trx_finality_status_forked_if_test
2d9b5ab
@heifner
GH-1510 Add trx_finality_status_if_test
6e9fff5
@heifner
GH-1510 Add ship_streamer_if_test disabled requires GH-2172
8f016e6
@heifner heifner marked this pull request as ready for review January 31, 2024 14:11
linh2931
linh2931 reviewed Jan 31, 2024
View reviewed changes
tests/CMakeLists.txt Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@heifner heifner merged commit c20eea0 into hotstuff_integration Jan 31, 2024
24 of 26 checks passed
@heifner heifner deleted the GH-1510-integration-if-tests branch January 31, 2024 17:58
@heifner heifner mentioned this pull request Jan 31, 2024
Closed
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: TEST
summary: Additional tests covering areas for read-only-trx, snapshots, restarts, and forks among others. Second large testing PR for Faster Finality.
Note: end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heifner @ericpassmore @greg7mdp @linh2931