Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: remove chain_pacemaker and qc_chain related files #2146

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Jan 26, 2024

Remove chain_pacemaker and qc_chain related files and tests. Do the removal now so that we don't need to maintain the tests using qc_chain and chain_pacemaker while making changes to common files.

Porting tests to work with the new implementation is tracked by #2147.

Resolved #2123.

@linh2931 linh2931 requested review from greg7mdp and heifner January 26, 2024 20:35
@linh2931 linh2931 requested a review from heifner January 28, 2024 18:45
@linh2931 linh2931 changed the title IF: remove chain_pacemaker and qc_chain related files (Part 1) IF: remove chain_pacemaker and qc_chain related files Jan 28, 2024
@greg7mdp
Copy link
Contributor

lgtm, but I'm wondering if before removing all the tests that existed for the qc_chain implementation, we should not at least review them, and convert those which make sense for our new implementation of IF?

@heifner
Copy link
Member

heifner commented Jan 29, 2024

lgtm, but I'm wondering if before removing all the tests that existed for the qc_chain implementation, we should not at least review them, and convert those which make sense for our new implementation of IF?

That is what #2147 is for.

@linh2931
Copy link
Member Author

The adapting of the tests will be done by #2147 (It will be a significant work). The tests being removed do not cover any new implementation; removing them does not reduce our existing test coverage but saves us from updating them just for compile whenever we change some common data types.

@linh2931 linh2931 merged commit 3ed949a into hotstuff_integration Jan 29, 2024
26 checks passed
@linh2931 linh2931 deleted the remove_qc_chain branch January 29, 2024 15:21
@linh2931 linh2931 linked an issue Jan 29, 2024 that may be closed by this pull request
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: TEST
summary: Remove original pacemaker code and update tests to match current working code.
Note: end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IF: Remove chain_pacemaker and qc_chain related files and code
4 participants