Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Integration tests enabled for instant-finality (Part 1) #2124

Merged
merged 29 commits into from
Jan 29, 2024
Merged

IF: Integration tests enabled for instant-finality (Part 1) #2124

merged 29 commits into from
Jan 29, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 22, 2024 •
edited
Loading

Adding additional integration tests for instant-finality

  • block_log_util_if_test
  • block_log_retain_blocks_if_test
  • cluster_launcher_if
  • distributed-transactions-if-test
  • nodeos_forked_chain_if_lr_test
  • nodeos_contrl_c_if_test
  • nodeos_chainbase_allocation_if_test
  • nodeos_producer_watermark_if_lr_test
  • nodeos_high_transaction_if_lr_test
  • larger_lib_if_test
  • light_validation_sync_if_test
  • auto_bp_peering_if_test

There are more that need to be added, but this set gives us much more coverage than we currently have. Merging this now, and will add additional tests in a (Part 2).

@heifner heifner marked this pull request as draft January 22, 2024 18:22
@heifner heifner changed the title IF IF: Additional integration tests enabled for instant-finality Jan 22, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Jan 22, 2024
@heifner
GH-1510 Add eosio bls key. Fix finality setting
1bb46d7
@heifner
GH-1510 Add block_log_retain_blocks_if_test
a6d42a8
@heifner
GH-1510 Add block_log_util_if_test
9088f33
@heifner
GH-1510 Add cluster_launcher_if test
14dad4b
@heifner
GH-1510 Remove unneeded threshold reduction
cc11309
@heifner
GH-1510 Add distributed-transactions-if-test. Switch compute_transact…
a18eb0f 
…ion_test & get_account_test to use instant-finality.
@heifner
GH-1510 Exclude bios node from finalizer set unless needed
f087acd
@heifner
GH-1510 Allow test to indicate if bios node should be a finalizer
eca46af
@heifner
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-1510…
6b0e1cd 
…-tests-if
@heifner
GH-1510 Handle common case of nodes killed during a test
68ec165
@heifner
GH-1510 Add larger_lib_if_test
1244d15
@heifner
GH-1510 Remove hs_ nomenclature
7e58cf7
@heifner
GH-1510 Add light_validation_sync_if_test
10f8949
@heifner
GH-1510 Add nodeos_chainbase_allocation_if_test and nodeos_contrl_c_i…
8da1041 
…f_test. Run nested_container_multi_index_test.py with instant-finality enabled.
@heifner
GH-1510 Run nodeos_extra_packed_data_test.py in instant-finality mode
b1c6b42
@heifner
GH-1510 Enabled long running distributed-transactions-test, add distr…
c00bf81 
…ibuted_transactions_if_lr_test
@heifner heifner mentioned this pull request Jan 25, 2024
Merged
@heifner heifner changed the title IF: Additional integration tests enabled for instant-finality IF: Integration tests enabled for instant-finality (Part #1) Jan 26, 2024
@heifner heifner changed the title IF: Integration tests enabled for instant-finality (Part #1) IF: Integration tests enabled for instant-finality (Part 1) Jan 26, 2024
@heifner heifner marked this pull request as ready for review January 26, 2024 15:08
linh2931
linh2931 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those should be checked in as soon as possible so we don't introduce new bugs while busy writing large amount of new code.

tests/CMakeLists.txt Show resolved Hide resolved
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: TEST
summary: Added tests to cover more scenarios including block_log, forked chain, larger lib, auto peering, and distributed transactions.
Note: end

@arhag arhag linked an issue Jan 29, 2024 that may be closed by this pull request
IF: Refactor integration tests to support legacy & IF consensus in parallel #1510
Closed
@heifner heifner merged commit 10b386a into hotstuff_integration Jan 29, 2024
26 checks passed
@heifner heifner deleted the GH-1510-tests-if branch January 29, 2024 23:30
@heifner heifner mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: Refactor integration tests to support legacy & IF consensus in parallel
4 participants
@heifner @ericpassmore @greg7mdp @linh2931