IF: Unification: add latest commit QC known to proposer to block extension (final part) #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Jan 16, 2024
libraries/chain/controller.cpp
Outdated
| auto bsp = std::make_shared<block_state>(ab.bhs, std::move(ab.trx_metas), | ||
| std::move(ab.trx_receipts)); | ||
| std::move(ab.trx_receipts), qc); |
There was a problem hiding this comment.
Actually, I see no reason to copy it at all. Pass the ab.qc to block_state constructor as const std::optional<quorum_certificate>& and do the is_needed check in block_state constructor and pack *qc there.
heifner
reviewed
Jan 16, 2024
greg7mdp
approved these changes
Jan 16, 2024
heifner
approved these changes
Jan 16, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2011. Add QC to block extension if needed.
Resolved #1586