Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Add IF activation to integration test framework #1998

Merged
merged 14 commits into from
Dec 20, 2023
Merged

IF: Add IF activation to integration test framework #1998

merged 14 commits into from
Dec 20, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Dec 18, 2023 •
edited
Loading

  • Adds ability to activate instant finality to the integration test framework, specifically Cluster.py launch().
    • Unique BLS keys and proof-of-possession is created for each test run similar to proposer keys.
    • Added example in tests/distributed-transactions-test.py & tests/nodeos_run_test.py
    • If we are happy with this approach, it can be added to all integration tests and new cmake tests can be added that use it.
      • Currently LIB is not progressing after activation.
  • Updated tutorials/bios-boot-tutorial/bios-boot-tutorial.py to include INSTANT_FINALITY activation.
  • Updated Cluster.py to use eosio.boot contract for protocol feature activation instead of old bios contract.
  • Updated Cluster.py to use new setprods of the bios contract.
  • Updated prod_preactivation_test.py to work as before without needing old bios contracts to be setup by Cluster.py.

@heifner heifner mentioned this pull request Dec 18, 2023
Closed
@heifner heifner added the OCI Work exclusive to OCI team label Dec 19, 2023
@heifner heifner marked this pull request as ready for review December 19, 2023 16:20
@heifner heifner linked an issue Dec 19, 2023 that may be closed by this pull request
IF: Refactor integration tests to support legacy & IF consensus in parallel #1510
Closed
linh2931
linh2931 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. We should see actual IF activation when other parts of code are in.

greg7mdp
greg7mdp approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@greg7mdp greg7mdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@heifner heifner merged commit e91c9fb into hotstuff_integration Dec 20, 2023
29 checks passed
@heifner heifner deleted the GH-1510-activate-if-tests branch December 20, 2023 00:46
@heifner heifner mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: Refactor integration tests to support legacy & IF consensus in parallel
3 participants
@heifner @greg7mdp @linh2931