Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] Gh 1743 add context to exceptions #1902

Closed
wants to merge 12 commits into from
Closed

[5.0] Gh 1743 add context to exceptions #1902

wants to merge 12 commits into from

Conversation

YaroShkvorets
Copy link
Contributor

linh2931 and others added 12 commits October 5, 2023 22:01
@linh2931
merge 5.0.0-rc-1 and correct Leap version
dfdd091
@linh2931
Merge pull request AntelopeIO#1727 from AntelopeIO/merge_5_0_0_rc_1
f5a98fe 
[5.0 -> main] Merge release/5.0.0-rc1 to main and make main branch version to 5.1.0-dev
@heifner
Merge pull request AntelopeIO#1731 from AntelopeIO/GH-1716-GH-1490-ma…
09bebdf 
…in-fixes-main

[5.0 -> main] Fix possible segfault switching between read/write windows
@heifner
Merge remote-tracking branch 'origin/release/5.0' into AntelopeIOGH-1501
992357b 
-retry-main
@heifner
Merge pull request AntelopeIO#1737 from AntelopeIO/AntelopeIOGH-1501-…
6ffebba 
…retry-main

[5.0 -> main] Test: Retry set contract on failure
@heifner
Merge remote-tracking branch 'origin/release/5.0' into AntelopeIOGH-1688
6e96184 
-cleos-err-main
@heifner
Merge pull request AntelopeIO#1738 from AntelopeIO/AntelopeIOGH-1688-…
6bd77ce 
…cleos-err-main

[5.0 -> main] Improve cleos error messages
@heifner
Merge remote-tracking branch 'origin/release/5.0' into AntelopeIOGH-1501
ca109d6 
-retry-retry-main
@heifner
Merge pull request AntelopeIO#1740 from AntelopeIO/AntelopeIOGH-1501-…
3470458 
…retry-retry-main

[5.0 -> main] Test: Pass in exitOnError so that a retry is allowed
@YaroShkvorets
add action context to exception
23bda8e 
ref AntelopeIO#1743
@YaroShkvorets
change error message format
e6dc6da
@YaroShkvorets
update version
a046bd5
@YaroShkvorets YaroShkvorets changed the title Gh 1743 add context to exceptions [5.0] Gh 1743 add context to exceptions Nov 14, 2023
@YaroShkvorets YaroShkvorets mentioned this pull request Nov 14, 2023
Merged
heifner
heifner requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-implement this on top of a release/5.0 branch to make the commit history cleaner please.

@YaroShkvorets
Copy link
Contributor Author

Will do

@YaroShkvorets YaroShkvorets deleted the GH-1743-add-context-to-exceptions branch November 14, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YaroShkvorets @heifner @linh2931