-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Minimize abort/start block for speculative blocks #1845
Conversation
…lation not based on now
tests/TestHarness/Node.py
Outdated
duplicateBlockNumbers.add(blockNumber) | ||
blockNumbers.add(blockNumber) | ||
|
||
if duplicatesFound: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if the same Start Block is spread across two stderr files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if
is inside the loop over the files. The first file that is found with a duplicate the verify stops. Might be better to scan all files for reporting. I'll make that change.
tests/TestHarness/Node.py
Outdated
for f in files: | ||
blockNumbers = set() | ||
duplicateBlockNumbers = set() | ||
duplicatesFound = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should "duplicate" be renamed as only 3 or more is a failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed
Simplify and fix issues with #1481 block deadline calculation. Remove the concept of a hard deadline as producers want to produce a block even if the deadline has passed for the block. This uses a conservative calculation for producer wake up time, but does verify it is in the future.
Resolves #1837