Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Minimize abort/start block for speculative blocks #1845

Merged
merged 10 commits into from
Nov 1, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 31, 2023

Simplify and fix issues with #1481 block deadline calculation. Remove the concept of a hard deadline as producers want to produce a block even if the deadline has passed for the block. This uses a conservative calculation for producer wake up time, but does verify it is in the future.

Resolves #1837

@heifner heifner linked an issue Oct 31, 2023 that may be closed by this pull request
@heifner heifner requested review from linh2931 and greg7mdp October 31, 2023 21:05
@heifner heifner added the OCI Work exclusive to OCI team label Oct 31, 2023
tests/TestHarness/Node.py Show resolved Hide resolved
tests/TestHarness/Node.py Show resolved Hide resolved
duplicateBlockNumbers.add(blockNumber)
blockNumbers.add(blockNumber)

if duplicatesFound:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the same Start Block is spread across two stderr files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if is inside the loop over the files. The first file that is found with a duplicate the verify stops. Might be better to scan all files for reporting. I'll make that change.

for f in files:
blockNumbers = set()
duplicateBlockNumbers = set()
duplicatesFound = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should "duplicate" be renamed as only 3 or more is a failure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed

plugins/producer_plugin/producer_plugin.cpp Show resolved Hide resolved
@heifner heifner merged commit a993c02 into release/5.0 Nov 1, 2023
29 checks passed
@heifner heifner deleted the GH-1837-start-block-5.0 branch November 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.0: lots of "not producing block" messages on the backup BP
3 participants