Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0 -> main] fix new signedness warnings to have a clean build for rc3 #1838

Closed
wants to merge 2 commits into from

Conversation

linh2931
Copy link
Member

Fix new warnings so we have a clean rc3 build

plugins/net_plugin/tests/rate_limit_parse_unittest.cpp:23:4:   required from here
libraries/boost/libs/test/include/boost/test/tools/old/impl.hpp:107:17: warning: comparison of integer expressions of different signedness: ‘const long unsigned int’ and ‘const int’ [-Wsign-compare]

...

plugins/state_history_plugin/tests/session_test.cpp:488:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘const uint32_t’ {aka ‘const unsigned int’} [-Wsign-compare]
  488 |       for (int i = 0; i < head; ++i) {
      |                       ~~^~~~~~

Merges release/5.0 into main including #1836

Resolves #1835

linh2931 and others added 2 commits October 27, 2023 10:10
[5.0] fix new signedness warnings to have a clean build for rc3
@linh2931 linh2931 requested review from greg7mdp and heifner October 27, 2023 18:12
@linh2931
Copy link
Member Author

linh2931 commented Oct 27, 2023

Close this as base branch was wrong (directly from release/5.0).

Replaced by #1839.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new compile warnings
2 participants