[5.0 -> main] Increase max-transaction-time for read_only_trx unit tests #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Increase max-transaction-time for setting bios contract * Refactor tests to use common command line arguments
…e_readony_tests_5_0 [5.0] Increase max-transaction-time for read_only_trx unit tests
…ransaction_time_readony_tests_main
heifner
approved these changes
Oct 26, 2023
greg7mdp
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max-transaction-timein read_only_trxs tests was originally set to 10000us. That's beforeactivate_protocol_features_set_bios_contractwas added.activate_protocol_features_set_bios_contractcallsset_codeto set bios contracts which can take more than 10000us; this causes the tests to fail.This PR
Merges release/5.0 into main including #1819
Resolves #1816