[5.0 -> main] make resource monitor plugin tests deterministic by using fixed fc::temp_directory instead of dynamic /tmp #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc::temp_directory instead of dynamic /tmp
[5.0] make resource monitor plugin tests deterministic by using fixed fc::temp_directory instead of dynamic /tmp
…nistic_tests_main
heifner
approved these changes
Oct 26, 2023
greg7mdp
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several resource monitor plugin tests use native
/tmpas a monitored directory for testing. However, subdirectories in/tmpon test machine can be removed during a test run, causingfile_space_handler::add_file_systemto assert when doingget_staton a removed directory, as shown by following failure:/__w/leap/leap/plugins/resource_monitor_plugin/test/test_resmon_plugin.cpp(147): fatal error: in "resmon_plugin_tests/startupNormal": unexpected exception thrown by plugin_startup({"/tmp"})I manually simulated a removed directory and reproduced the same failure.
This PR
fc::temp_directoryinstead of/tmp.Merges release/5.0 into main including #1826
Resolves #1824