Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically create experimental-binaries package on release #1795

Closed
wants to merge 1 commit into from

Conversation

spoonincode
Copy link
Member

The experimental-binaries package is where we stash away some versioned packages that are not fully supported but we want indefinitely (they would eventually expire as a workflow artifact). Historically we've used this for leap-dev.deb which is used in CI, and ARM packages for DUNE -- both packages we don't fully support thus don't want them highly visible as a release asset.

Now that we're no longer creating ARM packages for DUNE, we can go ahead and automatically create the experimental-binaries package that solely stores leap-dev.deb. This is a rather obtuse procedure that has been done manually so automating it is a great improvement.

Clearly one of the problems with reviewing this is.. how to test it?! I don't have a good answer for that. I developed and tested it manually in a private repo. I think we'll just have to iterate on it if it doesn't work for future releases 😕

I made some changes to asset-artifact-download-action as part of this work -- AntelopeIO/asset-artifact-download-action#4. This got YOLOed merged but we can refine it some more if something comes out of the review. (we want the new wait-for-exact-target feature here so if someone releases before CI is complete at that ref, we wait around for CI to complete so we can upload

⚠️ 5.0 is the first version that has both a ubuntu20 & ubuntu22 leap-dev.deb; this might confuse existing workflows that just install leap-dev*.deb or such -- they might get the package for a different ubuntu version then they're running.

Resolves #1781

@spoonincode spoonincode added the CICD Anything dealing with the CI workflow behavior label Oct 18, 2023
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want this target to release\5.0 branch?

@spoonincode
Copy link
Member Author

For some reason I was under the impression that release triggers always run what's in main (default branch).. but I'm glad you asked since that's not true after looking/experimenting again! They do run with the workflow on the released commit.

So yes, this should be sent back to at least 4.0... maybe even potentially 3.2 as we still have unreleased commits on that branch?

@linh2931
Copy link
Member

Or if you want it to be safe, do release/5.0 first. If it works as expected, then back port to 3.2 and 4.0.

@spoonincode
Copy link
Member Author

replacing with #1797 targeting 5.0, thanks @linh2931

@spoonincode spoonincode deleted the eb branch October 19, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD Anything dealing with the CI workflow behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatically create experimental-binaries package on release
2 participants