Implement DISABLE_DEFERRED_TRXS_STAGE_1 and DISABLE_DEFERRED_TRXS_STAGE_2 protocol features #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GE_2 protocol features
…LE_DEFERRED_TRXS_STAGE_1 is activated
…age_1 and disable_deferred_trxs_stage_2 are activated
…_2 from full protocol feature activation in tests
heifner
reviewed
Sep 29, 2023
…cannot have disable_deferred_trx protocol features activated
…e_deferred_trxs_stage_1 programmably
…ion, revert unnecessary eosio_assert in its activation, and update the test
heifner
requested changes
Oct 2, 2023
heifner
requested changes
Oct 2, 2023
…ed_trxs_stage_1) outside of while loop
heifner
approved these changes
Oct 2, 2023
…ferred host function
…deferred_trxs_stage_1 activation
arhag
requested changes
Oct 3, 2023
…1 and improve comments about disable_deferred_trxs_stage_1 rules
…ginal full policy for deep-mind test and update deep-mind log
…d in deferred trxs
…that block_id is the same (needed for deep-mind test)
…rotocol_features are activated
arhag
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #1555
Once
DISABLE_DEFERRED_TRXS_STAGE_1is activated, the behavior of thesend_deferredandcancel_deferredhost functions andcanceldelaynative action changes so that they become no-ops. In addition, a block will expire deferred transactions until it reaches the hard-coded wall-clock deadline for that block; any block that retires a deferred transaction with a status other than expired is invalid. Also, a deferred transaction can be retired as expired at any time regardless of whether its delay_until or expiration times have been reached.DISABLE_DEFERRED_TRXS_STAGE_2depends onDISABLE_DEFERRED_TRXS_STAGE_11. On activation ofDISABLE_DEFERRED_TRXS_STAGE_2`, its activation handler iterates through any remaining deferred transactions to refund the RAM paid for the sender of that deferred transaction and to delete the deferred transaction from the state. All deferred transactions are cleared out within the activation handler.