Chainbase should balk on 3.1-4.0 chainbases #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Sep 29, 2023
|
includes AntelopeIO/chainbase#20 & AntelopeIO/chainbase#23 |
spoonincode
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1570 .
Updates chainbase to tip of
mainbranch, where the version marker embedded in thechainbasedb file was updated (in order for Leap 5.0 to not try loading chainbases dbs in the old format).Here is the error displayed when this is attempted (Loading a Leap
3.1.1db into5.0):We could probably make the error display more user-friendly, i.e. state the likely cause of the problem and suggest a solution, However, I think this is a task that should be done holistically for all possible errors, and is deserving of its own issue.