Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PH] Trx Generator - Use default exception handler. #1692

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

oschwaldp-oci
Copy link
Contributor

@oschwaldp-oci oschwaldp-oci commented Sep 28, 2023

The non-default exception handler was masking the issue and not terminating the process which was causing misleading errors downstream. With default exception handler there is a better exception message as well as termination of the process. This provides better handling upstream in the performance harness.

This was being caused by an http response of ok with an empty string response body.

Using the default exception handler, the exception now looks like:

Fail to parse JSON from string:
    {"string":""}
    provider_connection-0  trx_provider.cpp:172 operator()
unexpected end of file
    {}
    provider_connection-0  json.cpp:435 variant_from_stream

    {"str":""}
    provider_connection-0  json.cpp:461 from_string

terminate called after throwing an instance of 'eosio::chain::json_parse_exception'
  what():  JSON parse exception

Which terminates the trx_generator process and proper exit return code is passed back to the PerformanceHarness.

Relates to ongoing work in #1662

The non-default exception handler was masking the issue and not terminating the process which was causing misleading errors downstream. With default exception handler there is a better exception message as well as termination of the process. This provides better handling upstream in the performance harness.
@oschwaldp-oci oschwaldp-oci added the OCI Work exclusive to OCI team label Sep 28, 2023
@oschwaldp-oci oschwaldp-oci merged commit 7845335 into main Sep 28, 2023
22 checks passed
@oschwaldp-oci oschwaldp-oci deleted the oschwaldp/ph-fix branch September 28, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants