-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PH: Add a longer running read-only trx for tests #1685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwaldp-oci
approved these changes
Sep 27, 2023
linh2931
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the example in the PR description, which shows the read-only threads are occupied most of the time.
linh2931
approved these changes
Sep 27, 2023
oschwaldp-oci
suggested changes
Sep 27, 2023
Verify that doitslow action runs for at least 100us
oschwaldp-oci
approved these changes
Sep 27, 2023
linh2931
reviewed
Sep 27, 2023
if (p % i == 0) { | ||
prime = false; | ||
break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more clear.
linh2931
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logging-template.json
for tests instead of using the example one inprograms/nodeos
since the configuredgelf
logging was wasting a thread and cpu when no gelf logging is being used in tests.doitslow
action topayloadless
contract for use in tests and performance harness runs.Example of using the new longer running read-only trx in a performance run:
https://github.com/AntelopeIO/leap/actions/runs/6318554443
Which means 1000*6549=6,549,000us worth of trx execution within a 1,000,000us window.