-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PH] Performance Harness Updates #1667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and read-only-read-window-time-us. Make default write window smaller and read window larger during read only tests (testApiOpMode).
Allows the workflow to be run on a specific branch to get a specific version of the Performance Harness while allowing the tester to override which version of nodeos and cleos should be tested.
… structure for cleos version.
…n testApiOpMode as it breaks backward compatibility.
heifner
approved these changes
Sep 22, 2023
heifner
approved these changes
Sep 22, 2023
spoonincode
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command line config parameters for
read-only-write-window-time-us
andread-only-read-window-time-us
.testApiOpMode
for testing read-only transactions, defaultread-only-write-window-time-us
to1000
andread-only-read-window-time-us
to165000
.Add configurable
leap-target
override. Allows the workflow to be run on a specific branch to get a specific version of the Performance Harness while allowing the tester to override which version ofnodeos
andcleos
should be tested../tests/PerformanceHarnessScenarioRunner.py findMax testApiOpMode --max-tps-to-test 500 --test-iteration-min-step 10 --test-iteration-duration-sec 10 --final-iterations-duration-sec 10 overrideBasicTestConfig -v --tps-limit-per-generator 250
"nodeosVersion": "v4.1.0-dev-defc8a18747ccafd3dda7f25a0abdd9c4281c0e9"
: https://github.com/AntelopeIO/leap/actions/runs/62748274134.0
. Test report logs"nodeosVersion": "v4.0.4-7e1ad13e1e98b1e0703d0ea072b4fca5419cfdbe"
: https://github.com/AntelopeIO/leap/actions/runs/62748317503.2
. Test report logs"nodeosVersion": "v3.2.4-00b045ca2c3d66375eee8f196a7f9e9866bf2344"
.: https://github.com/AntelopeIO/leap/actions/runs/6274834374Fix when
_acknowledged
is incremented to allow completion of logging of ack data prior to signaling the acknowledgment.Update
ph_backward_compatibility.yaml
workflow to usenodeos --full-version
andcleos version full
for logging the versions installed. This will help pinpoint which exact version in time was used for a given test run to allow better reproducibility of results. Also use full versions inperformance_harness_run.yaml
.Work relates to ongoing issue: #1634