-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor adding EosioChain INTERFACE library for use in add_eosio_test_executable macro and by itself. #1638
Conversation
These dependencies allow for additional use of add_eosio_test_executable outside of leap for executables loosely defined as test artifacts. For example, compiling a transaction generator in another repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How difficult would it be to refactor this cmake file to present maybe a add_library(libtester STATIC IMPORTED)
. Then the existing add_eosio_test_executable
would just link to the IMPORTED libtester
, but when you're not making a test executable you would just target_link_libraries(whatever libtester)
Adding dependencies like this makes it difficult to know the union of all downstream dependencies when reviewing this file in the future.
@spoonincode -- How about going the direction of an |
Yes true, |
Fix target_include_directories for EosioTesterBuild.cmake.in
Some cleanup as well.
This refactor creates an
INTERFACE
library calledEosioChain
which can be used externally toleap
as a library fortarget_link_libraries
. In an repository that wants to depend on and link againstEosioChain
, it can now be done by simply: