Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Use bls12_381::pop_prove to generate POP and add get_pop_str method to libfc #1625

Merged
merged 4 commits into from
Sep 13, 2023
Merged

IF: Use bls12_381::pop_prove to generate POP and add get_pop_str method to libfc #1625

merged 4 commits into from
Sep 13, 2023

Conversation

linh2931
Copy link
Member

Fixed #1525 to use BLS library pop_prove to generate POP.

  • Added get_pop_str to libfc bls_private_key using pop_prove;
  • Modified leap-util to use get_pop_str;
  • Updated the test.

arhag
arhag requested changes Sep 12, 2023
View reviewed changes
libraries/libfc/include/fc/crypto/bls_private_key.hpp Outdated Show resolved Hide resolved
tests/leap_util_bls_test.py Outdated Show resolved Hide resolved
dimas1185
dimas1185 suggested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@dimas1185 dimas1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include this update (should be in a main branch of bls):
AntelopeIO/bls12-381#11

@linh2931 linh2931 merged commit b3d2aca into hotstuff_integration Sep 13, 2023
22 checks passed
@linh2931 linh2931 deleted the sign_pop_correctly branch September 13, 2023 11:22
@arhag arhag linked an issue Sep 13, 2023 that may be closed by this pull request
IF: Generate BLS key pairs in leap-util #1525
Closed
@ericpassmore
Copy link
Contributor

ericpassmore commented Oct 12, 2023 •
edited
Loading

Note:start
group: IF
category: MESSAGES
summary: Generate Proof of Possession Key with raw, affine, little-endian format
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimas1185 dimas1185 dimas1185 approved these changes

@arhag arhag arhag approved these changes

@heifner heifner heifner approved these changes

@mschoenebeck mschoenebeck Awaiting requested review from mschoenebeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: Generate BLS key pairs in leap-util
5 participants
@linh2931 @ericpassmore @heifner @arhag @dimas1185